flipdot/drinks-touch
22
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions 3

Fix #1: Add global drink statistics #5

Merged
soerface merged 6 commits from issue-1_drinks-stats into main 2026-03-29 22:34:25 +00:00
Conversation 3 Commits 6 Files changed 7 +121 -89
soerface commented 2026-03-29 22:15:00 +00:00
Owner
Copy link
No description provided.
Show a barchart as the background of the table row
Some checks are pending
CI / CI optimization (pull_request) Waiting to run
Details
CI / Release (semantic, dry) (pull_request) Blocked by required conditions
Details
CI / pre-commit (pull_request) Blocked by required conditions
Details
CI / Build (pull_request) Blocked by required conditions
Details
CI / Release (semantic) (pull_request) Blocked by required conditions
Details
3bc6a04d36
Lenny reviewed 2026-03-29 22:21:10 +00:00
drinks_touch/webserver/blueprints/stats.py Outdated
@ -0,0 +24,4 @@
except ValueError:
# Fallback to default dates if format is invalid
from_date = date.today() - timedelta(days=30)
to_date = date.today()
Lenny commented 2026-03-29 22:21:10 +00:00
Owner
Copy link
  1. Die defaults stehen so zwei mal im code.
  2. Ich glaub wenn nur eins von beiden failed werden beide auf den default gesetzt

Wieso nicht sowas wie (pseudocode I'm not a python)

from_date = date.today() - timedelta(days=30)
to_date = date.today()

try:
  from_date = date.fromisoformat(request.form.get("from"))
except:
  # nothing

try:
  to_date = date.fromisoformat(request.form.get("to"))
except:
  # nothing
1. Die defaults stehen so zwei mal im code. 2. Ich glaub wenn nur eins von beiden failed werden beide auf den default gesetzt Wieso nicht sowas wie (pseudocode I'm not a python) ```python from_date = date.today() - timedelta(days=30) to_date = date.today() try: from_date = date.fromisoformat(request.form.get("from")) except: # nothing try: to_date = date.fromisoformat(request.form.get("to")) except: # nothing ```
soerface commented 2026-03-29 22:22:22 +00:00
Author
Owner
Copy link

Joah hast schon recht, war nur faul. Sekunde, ich push was in der Richtung

Joah hast schon recht, war nur faul. Sekunde, ich push was in der Richtung
🚀 1
soerface commented 2026-03-29 22:26:24 +00:00
Author
Owner
Copy link

Thx, fixed! Statt default am Anfang, default im except block

Thx, fixed! Statt default am Anfang, default im except block
👍 1
Simplify from / to date parsing
Some checks are pending
CI / CI optimization (pull_request) Waiting to run
Details
CI / Release (semantic, dry) (pull_request) Blocked by required conditions
Details
CI / pre-commit (pull_request) Blocked by required conditions
Details
CI / Build (pull_request) Blocked by required conditions
Details
CI / Release (semantic) (pull_request) Blocked by required conditions
Details
f0222d7fa2
soerface commented 2026-03-29 22:27:12 +00:00
Author
Owner
Copy link

Screenshot im Ticket, falls jemand sich den Style anschauen mag ohne Projekt auszuchecken: #1 (comment)

Screenshot im Ticket, falls jemand sich den Style anschauen mag ohne Projekt auszuchecken: https://code.flipdot.org/flipdot/drinks-touch/issues/1#issuecomment-905
Lenny approved these changes 2026-03-29 22:29:36 +00:00
Lenny left a comment
Owner
Copy link

LGTM 👍

LGTM 👍
Remove "Home" link from navbar
Some checks failed
CI / CI optimization (pull_request) Has been cancelled
Details
CI / Release (semantic, dry) (pull_request) Has been cancelled
Details
CI / pre-commit (pull_request) Has been cancelled
Details
CI / Build (pull_request) Has been cancelled
Details
CI / Release (semantic) (pull_request) Has been cancelled
Details
4b26839b92
soerface deleted branch issue-1_drinks-stats 2026-03-29 22:34:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Lenny
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
malled
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
flipdot/drinks-touch!5
No description provided.